chrome/browser/ui/cocoa/tabpose_window.mm - Issue 10945010: Switch BookmarkTabHelper to use WebContentsUserData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabpose_window.mm

Issue 10945010: Switch BookmarkTabHelper to use WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/tabpose_window.mm

diff --git a/chrome/browser/ui/cocoa/tabpose_window.mm b/chrome/browser/ui/cocoa/tabpose_window.mm

index db93648dc950989ba500a358bc9eea30210cfff3..af1f9260fd1d5754f146432339ef86f8415ef5c1 100644

--- a/chrome/browser/ui/cocoa/tabpose_window.mm

+++ b/chrome/browser/ui/cocoa/tabpose_window.mm

@@ -237,10 +237,12 @@ void ThumbnailLoader::LoadThumbnail() {

[infoBarContainer overlappingTipHeight];

}

+ BookmarkTabHelper* bookmark_tab_helper =

+ BookmarkTabHelper::FromWebContents(contents_->web_contents());

bool always_show_bookmark_bar =

contents_->profile()->GetPrefs()->GetBoolean(prefs::kShowBookmarkBar);

bool has_detached_bookmark_bar =

- contents_->bookmark_tab_helper()->ShouldShowBookmarkBar() &&

+ bookmark_tab_helper->ShouldShowBookmarkBar() &&

!always_show_bookmark_bar;

if (has_detached_bookmark_bar)

topOffset += bookmarks::kNTPBookmarkBarHeight;