Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10945010: Switch BookmarkTabHelper to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, browser-components-watch_chromium.org, dcheng, Aaron Boodman, ajwong+watch_chromium.org
Visibility:
Public.

Description

Switch BookmarkTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157456

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -146 lines) Patch
M chrome/browser/bookmarks/bookmark_manager_extension_api.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component/web_contents_delegate_android/web_contents_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_aura.h View 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_aura.cc View 4 chunks +18 lines, -19 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.h View 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.cc View 1 6 chunks +26 lines, -28 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_mac.h View 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm View 1 chunk +16 lines, -17 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_win.h View 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_win.cc View 2 chunks +19 lines, -20 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.h View 4 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_adoption.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/action_box_menu_model.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Please review.
8 years, 3 months ago (2012-09-18 21:26:04 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-09-18 21:39:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10945010/3002
8 years, 3 months ago (2012-09-18 21:50:18 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 00:08:59 UTC) #4 
Change committed as 157456

Powered by Google App Engine
This is Rietveld 408576698