Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 10945009: Add ExtensionInstalledBubbleBundle.xib to the mac_untranslated_xibs list. (Closed)

Created:
8 years, 3 months ago by Robert Sesek
Modified:
8 years, 3 months ago
Reviewers:
Nico, marja
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add ExtensionInstalledBubbleBundle.xib to the mac_untranslated_xibs list. Somehow this got lost in the move. BUG=150569, 149763 TEST=browser_tests:ExtensionWebstorePrivateBundleTest.Install* after clobber NOTRY=true TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157354

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/chrome_nibs.gypi View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
Robert Sesek
This file was missing, so after a clobber, the NIB wasn't being copied into the ...
8 years, 3 months ago (2012-09-18 14:45:35 UTC) #1
marja
lgtm
8 years, 3 months ago (2012-09-18 14:46:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10945009/1
8 years, 3 months ago (2012-09-18 14:47:04 UTC) #3
commit-bot: I haz the power
Presubmit check for 10945009-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-18 14:47:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10945009/1
8 years, 3 months ago (2012-09-18 14:47:47 UTC) #5
commit-bot: I haz the power
Change committed as 157354
8 years, 3 months ago (2012-09-18 14:48:03 UTC) #6
Nico
8 years, 3 months ago (2012-09-19 00:46:27 UTC) #7
lgtm

https://chromiumcodereview.appspot.com/10945009/diff/1/chrome/chrome_nibs.gypi
File chrome/chrome_nibs.gypi (right):

https://chromiumcodereview.appspot.com/10945009/diff/1/chrome/chrome_nibs.gyp...
chrome/chrome_nibs.gypi:56: 'app/nibs/ExtensionInstalledBubbleBundle.xib',
ExtensionInstalledBubble.xib is in the other list. I suppose that's intentional.

Powered by Google App Engine
This is Rietveld 408576698