Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10944019: Support simultaneous notification and bubble promos. (Closed)

Created:
8 years, 3 months ago by achuithb
Modified:
8 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Visibility:
Public.

Description

Support simultaneous notification and bubble promos. BUG=NONE TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/web_resource/notification_promo.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
achuithb
Please review.
8 years, 3 months ago (2012-09-18 22:45:38 UTC) #1
Dan Beam
lgtm, that was easy?
8 years, 3 months ago (2012-09-18 22:51:09 UTC) #2
achuithb
On 2012/09/18 22:51:09, Dan Beam wrote: > lgtm, that was easy? I'd assumed it was ...
8 years, 3 months ago (2012-09-18 22:54:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/10944019/1
8 years, 3 months ago (2012-09-18 22:58:58 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 03:55:42 UTC) #5 
Change committed as 157482

Powered by Google App Engine
This is Rietveld 408576698