Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10944016: Switch SearchTabHelper to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, ajwong+watch_chromium.org, tfarina, sadrul
Visibility:
Public.

Description

Switch SearchTabHelper to use WebContentsUserData. Also switches the rest of browser/ui/search to WebContents. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157564

Patch Set 1 #

Total comments: 3

Patch Set 2 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -119 lines) Patch
M chrome/browser/ui/browser.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_delegate.h View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/search/search_delegate.cc View 2 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/ui/search/search_delegate_unittest.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/search/search_model.h View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/ui/search/search_model.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 1 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 1 4 chunks +18 lines, -11 lines 0 comments Download
M chrome/browser/ui/search/toolbar_search_animator.h View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/search/toolbar_search_animator.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/search/toolbar_search_animator_observer.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/search/toolbar_search_animator_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/search_view_controller.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 6 chunks +17 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
Please review.
8 years, 3 months ago (2012-09-18 21:26:09 UTC) #1
sky
LGTM with the following changes https://codereview.chromium.org/10944016/diff/1/chrome/browser/ui/search/search_tab_helper.cc File chrome/browser/ui/search/search_tab_helper.cc (right): https://codereview.chromium.org/10944016/diff/1/chrome/browser/ui/search/search_tab_helper.cc#newcode33 chrome/browser/ui/search/search_tab_helper.cc:33: SearchTabHelper::SearchTabHelper(content::WebContents* web_contents) Move implementation ...
8 years, 3 months ago (2012-09-19 00:31:07 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/10944016/diff/1/chrome/browser/ui/search/search_tab_helper.cc File chrome/browser/ui/search/search_tab_helper.cc (right): https://codereview.chromium.org/10944016/diff/1/chrome/browser/ui/search/search_tab_helper.cc#newcode39 chrome/browser/ui/search/search_tab_helper.cc:39: Profile* profile = On 2012/09/19 00:31:07, sky wrote: > ...
8 years, 3 months ago (2012-09-19 14:42:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10944016/7001
8 years, 3 months ago (2012-09-19 15:31:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10944016/7001
8 years, 3 months ago (2012-09-19 15:31:42 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 17:57:16 UTC) #6 
Change committed as 157564

Powered by Google App Engine
This is Rietveld 408576698