Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 10944015: Enable DEP earlier on Vista and below (Closed)

Created:
8 years, 3 months ago by jschuh
Modified:
8 years, 2 months ago
CC:
chromium-reviews, cpu_(ooo_6.6-7.5)
Visibility:
Public.

Description

Enable DEP earlier on Vista and below We can't enable DEP at launch prior to Win7, but we can queue an APC to enable immediately after the loader finishes. BUG=147752 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162293

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M sandbox/win/src/process_mitigations.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M sandbox/win/src/process_mitigations.cc View 1 2 5 chunks +24 lines, -24 lines 8 comments Download
M sandbox/win/src/sandbox_policy_base.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jschuh
8 years, 3 months ago (2012-09-21 19:36:08 UTC) #1
jschuh
Rick, Carlos said he was okay with this if I convinced you of it. What ...
8 years, 2 months ago (2012-10-03 02:06:10 UTC) #2
rvargas (doing something else)
http://codereview.chromium.org/10944015/diff/12001/sandbox/win/src/process_mitigations.cc File sandbox/win/src/process_mitigations.cc (left): http://codereview.chromium.org/10944015/diff/12001/sandbox/win/src/process_mitigations.cc#oldcode255 sandbox/win/src/process_mitigations.cc:255: MITIGATION_BOTTOM_UP_ASLR | Are you losing these? http://codereview.chromium.org/10944015/diff/12001/sandbox/win/src/process_mitigations.cc File sandbox/win/src/process_mitigations.cc ...
8 years, 2 months ago (2012-10-03 02:42:37 UTC) #3
jschuh
http://codereview.chromium.org/10944015/diff/12001/sandbox/win/src/process_mitigations.cc File sandbox/win/src/process_mitigations.cc (left): http://codereview.chromium.org/10944015/diff/12001/sandbox/win/src/process_mitigations.cc#oldcode255 sandbox/win/src/process_mitigations.cc:255: MITIGATION_BOTTOM_UP_ASLR | On 2012/10/03 02:42:37, rvargas wrote: > Are ...
8 years, 2 months ago (2012-10-03 03:00:06 UTC) #4
rvargas (doing something else)
If you guys think that this is really worth it, I'm ok with it... so ...
8 years, 2 months ago (2012-10-03 22:23:57 UTC) #5
rvargas (doing something else)
lgtm
8 years, 2 months ago (2012-10-11 02:00:11 UTC) #6
rvargas (doing something else)
https://codereview.chromium.org/10944015/diff/12001/sandbox/win/src/process_mitigations.cc File sandbox/win/src/process_mitigations.cc (right): https://codereview.chromium.org/10944015/diff/12001/sandbox/win/src/process_mitigations.cc#newcode289 sandbox/win/src/process_mitigations.cc:289: if (!::QueueUserAPC(ApplyMitigationsCallback, target->MainThread(), btw, this breaks with the SANDBOX_EXPORTS ...
8 years, 2 months ago (2012-10-11 23:04:44 UTC) #7
cpu_(ooo_6.6-7.5)
lgtm
8 years, 2 months ago (2012-10-16 22:37:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/10944015/12001
8 years, 2 months ago (2012-10-16 22:37:42 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 00:37:53 UTC) #10
Change committed as 162293

Powered by Google App Engine
This is Rietveld 408576698