Issue 10944011: Clear EnumIndices as well on CNLT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10944011: Clear EnumIndices as well on CNLT. (Closed)

Created:
8 years, 3 months ago by Toon Verwaest

Modified:
8 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Clear EnumIndices as well on CNLT. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12542

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed nit #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -7 lines)			Patch
M	src/handles.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1	1 chunk	+16 lines, -2 lines	0 comments	Download
M	src/objects.cc	View		2 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 3 months ago (2012-09-19 07:58:41 UTC) #2

LGTM with nit.

https://chromiumcodereview.appspot.com/10944011/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/10944011/diff/1/src/objects.h#newcode2517
src/objects.h:2517: if (IsEmpty()) return false;;
nit: ;;

Expand Messages | Collapse Messages