Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellTestBase.java

Issue 10943014: Add support for the ChromiumTestShellTest APK. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed commented out gyp actions. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellTestBase.java
diff --git a/content/shell/android/javatests/src/org/chromium/content_shell/ContentShellTestBase.java b/chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellTestBase.java
similarity index 53%
copy from content/shell/android/javatests/src/org/chromium/content_shell/ContentShellTestBase.java
copy to chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellTestBase.java
index 59a6f7de77f2aa3e3706a1cba51c6b2734ff0910..86071d91be2f1b5bd012db8597d36ab589765290 100644
--- a/content/shell/android/javatests/src/org/chromium/content_shell/ContentShellTestBase.java
+++ b/chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellTestBase.java
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-package org.chromium.content_shell;
+package org.chromium.chrome.testshell;
import android.content.ComponentName;
import android.content.Intent;
@@ -10,24 +10,26 @@ import android.net.Uri;
import android.test.ActivityInstrumentationTestCase2;
/**
- * Base test class for all ContentShell based tests.
+ * Base test class for all ChromiumTestShell based tests.
*/
-public class ContentShellTestBase extends ActivityInstrumentationTestCase2<ContentShellActivity> {
+public class ChromiumTestShellTestBase extends
+ ActivityInstrumentationTestCase2<ChromiumTestShellActivity> {
- public ContentShellTestBase() {
- super(ContentShellActivity.class);
+ public ChromiumTestShellTestBase() {
+ super(ChromiumTestShellActivity.class);
}
/**
- * Starts the ContentShell activity and loads the given URL.
+ * Starts the ChromiumTestShell activity and loads the given URL.
*/
- protected ContentShellActivity launchContentShellWithUrl(String url) {
+ protected ChromiumTestShellActivity launchChromiumTestShellWithUrl(String url) {
Intent intent = new Intent(Intent.ACTION_MAIN);
intent.addCategory(Intent.CATEGORY_LAUNCHER);
intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
intent.setData(Uri.parse(url));
intent.setComponent(new ComponentName(getInstrumentation().getTargetContext(),
- ContentShellActivity.class));
- return (ContentShellActivity) getInstrumentation().startActivitySync(intent);
+ ChromiumTestShellActivity.class));
Ted C 2012/09/20 17:07:04 I think this needs +2 indent...looks like 6 to me.
David Trainor- moved to gerrit 2012/09/20 21:49:50 Done.
+ setActivityIntent(intent);
+ return getActivity();
}
}

Powered by Google App Engine
This is Rietveld 408576698