Adds two convenience functions for later use.

Adds two convenience functions for later use.

BUG=479059
Committed: https://chromium.googlesource.com/infra/infra/+/397ca49cdaa8f89529cead6785d66dbf7d094fe4

[ghost stip (do not use), 2015-04-21 06:38:59]

stip@chromium.org changed reviewers:
+ agable@chromium.org, iannucci@chromium.org

[ghost stip (do not use), 2015-04-21 06:39:08]

ptal (whoever gets to it first)

[agable, 2015-04-21 18:54:45]

On 2015/04/21 at 06:39:08, stip wrote:
> ptal (whoever gets to it first)

I'm all for implementing libraries, but since this library doesn't have a clear
structure or use-case, I'd prefer to wait to land it until something is actually
using it. Otherwise it is just "dead code".

That said, it seems like a good use for this would be to move some of the
functions from infra/libs/logs.py into here and have that rely on this to format
timestamps.

[tandrii(chromium), 2015-04-24 18:10:43]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2015-04-24 18:10:43]

lgtm

agable@ this is used in https://codereview.chromium.org/1097233002/ .

https://codereview.chromium.org/1094253002/diff/1/infra/libs/time_functions/t...
File infra/libs/time_functions/test/timestamp_test.py (right):

https://codereview.chromium.org/1094253002/diff/1/infra/libs/time_functions/t...
infra/libs/time_functions/test/timestamp_test.py:16:
self.assertEqual(timestamp.utctimestamp(my_date), sec_diff)
wdyt about emphasizing floatness of utctimestamp return type by
s/sec_diff/float(sec_diff) 
?

https://codereview.chromium.org/1094253002/diff/1/infra/libs/time_functions/t...
infra/libs/time_functions/test/timestamp_test.py:23: pst_diff = sec_diff - (8 *
3600.0)
well, this is implicitly float, but i'd still make it explicitely float on the
next line.

https://codereview.chromium.org/1094253002/diff/1/infra/libs/time_functions/t...
File infra/libs/time_functions/timestamp.py (right):

https://codereview.chromium.org/1094253002/diff/1/infra/libs/time_functions/t...
infra/libs/time_functions/timestamp.py:12: def utctimestamp(dt):
why no underscore? IMO, it's harder to read than utc_timestamp .
update: oh, well, datetime uses the same thing, ok, fine :(

[ghost stip (do not use), 2015-04-27 22:18:18]

https://chromiumcodereview.appspot.com/1094253002/diff/1/infra/libs/time_func...
File infra/libs/time_functions/test/timestamp_test.py (right):

https://chromiumcodereview.appspot.com/1094253002/diff/1/infra/libs/time_func...
infra/libs/time_functions/test/timestamp_test.py:16:
self.assertEqual(timestamp.utctimestamp(my_date), sec_diff)
On 2015/04/24 18:10:43, tandrii(chromium) wrote:
> wdyt about emphasizing floatness of utctimestamp return type by
> s/sec_diff/float(sec_diff) 
> ?

I believe the check will work anyway (1.0 == 1), but I'll go ahead and make the
change

https://chromiumcodereview.appspot.com/1094253002/diff/1/infra/libs/time_func...
infra/libs/time_functions/test/timestamp_test.py:23: pst_diff = sec_diff - (8 *
3600.0)
On 2015/04/24 18:10:43, tandrii(chromium) wrote:
> well, this is implicitly float, but i'd still make it explicitely float on the
> next line.

Done.

[ghost stip (do not use), 2015-04-27 22:18:22]

The CQ bit was checked by stip@chromium.org

[ghost stip (do not use), 2015-04-27 22:18:23]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1094253002/#ps40001
(title: "Address tandrii's comments.")

[commit-bot: I haz the power, 2015-04-27 22:18:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094253002/40001

[commit-bot: I haz the power, 2015-04-27 22:18:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 22:18:39]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[agable, 2015-04-28 00:44:33]

lgtm

[agable, 2015-04-28 00:44:42]

The CQ bit was checked by agable@chromium.org

[commit-bot: I haz the power, 2015-04-28 00:44:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094253002/40001

[commit-bot: I haz the power, 2015-04-28 00:47:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/397ca49cdaa8f89529cead6785d66...