Cleanup: avoid foo ? true : false, part 2.

net/url_request/url_request_file_dir_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_file_dir_job.h"
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
-#include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "base/time.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_util.h"
 #include "net/url_request/url_request_status.h"
 
@@ skipping 40 matching lines @@
 
   if (!list_complete_)
     lister_.Cancel();
 
   URLRequestJob::Kill();
 
   weak_factory_.InvalidateWeakPtrs();
 }
 
 bool URLRequestFileDirJob::ReadRawData(IOBuffer* buf, int buf_size,
-                                       int *bytes_read) {
+                                       int* bytes_read) {
   DCHECK(bytes_read);
   *bytes_read = 0;
 
   if (is_done())
     return true;
 
   if (FillReadBuffer(buf->data(), buf_size, bytes_read))
     return true;
 
   // We are waiting for more data
@@ skipping 36 matching lines @@
   }
 
 #if defined(OS_WIN)
   int64 size = (static_cast<unsigned __int64>(data.info.nFileSizeHigh) << 32) |
       data.info.nFileSizeLow;
 
   // Note that we should not convert ftLastWriteTime to the local time because
   // ICU's datetime formatting APIs expect time in UTC and take into account
   // the timezone before formatting.
   data_.append(GetDirectoryListingEntry(
-      data.info.cFileName, std::string(),
-      (data.info.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) ? true : false,
+      data.info.cFileName,
+      std::string(),
+      ((data.info.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) != 0),
       size,
       base::Time::FromFileTime(data.info.ftLastWriteTime)));
-
 #elif defined(OS_POSIX)
   // TOOD(jungshik): The same issue as for the directory name.
   data_.append(GetDirectoryListingEntry(
       WideToUTF16(base::SysNativeMBToWide(data.info.filename)),
       data.info.filename,
       S_ISDIR(data.info.stat.st_mode),
       data.info.stat.st_size,
       base::Time::FromTimeT(data.info.stat.st_mtime)));
 #endif
 
@@ skipping 27 matching lines @@
       SetStatus(URLRequestStatus());
       NotifyReadComplete(bytes_read);
     } else {
       NOTREACHED();
       // TODO: Better error code.
       NotifyDone(URLRequestStatus(URLRequestStatus::FAILED, 0));
     }
   }
 }
 
-bool URLRequestFileDirJob::FillReadBuffer(char *buf, int buf_size,
-                                          int *bytes_read) {
+bool URLRequestFileDirJob::FillReadBuffer(char* buf, int buf_size,
+                                          int* bytes_read) {
   DCHECK(bytes_read);
 
   *bytes_read = 0;
 
   int count = std::min(buf_size, static_cast<int>(data_.size()));
   if (count) {
     memcpy(buf, &data_[0], count);
     data_.erase(0, count);
     *bytes_read = count;
     return true;
   } else if (list_complete_) {
     // EOF
     return true;
   }
   return false;
 }
 
 }  // namespace net