lib/html/scripts/systemnative.py - Issue 10941047: Don't generate FooList if it behaves like List<Foo> exactly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/scripts/systemnative.py

Issue 10941047: Don't generate FooList if it behaves like List<Foo> exactly. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/html/scripts/systemnative.py

===================================================================

--- lib/html/scripts/systemnative.py (revision 12656)

+++ lib/html/scripts/systemnative.py (working copy)

@@ -430,7 +430,7 @@

def _AddSetter(self, attr, html_name):

type_info = self._TypeInfo(attr.type.id)

- dart_declaration = 'void set %s(%s)' % (html_name, self._DartType(attr.type.id))

+ dart_declaration = 'void set %s(%s value)' % (html_name, self._DartType(attr.type.id))

is_custom = set(['Custom', 'CustomSetter', 'V8CustomSetter']) & set(attr.ext_attrs)

cpp_callback_name = self._GenerateNativeBinding(attr.id, 2,

dart_declaration, 'Setter', is_custom)

« lib/html/scripts/systemhtml.py ('K') | « lib/html/scripts/systemhtml.py ('k') | lib/html/src/dart2js_Conversions.dart » ('j') | no next file with comments »