Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: content/renderer/browser_plugin/browser_plugin_bindings.cc

Issue 10941042: Browser plugin: Implement loadStart and loadAbort events (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed extra space Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_bindings.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_bindings.cc b/content/renderer/browser_plugin/browser_plugin_bindings.cc
index a9d5bb97b8666511ec7e5ba0ce2ff92c6d0f9437..104614ad238892a6209c5728cdaebabe9dd7348f 100644
--- a/content/renderer/browser_plugin/browser_plugin_bindings.cc
+++ b/content/renderer/browser_plugin/browser_plugin_bindings.cc
@@ -188,7 +188,10 @@ bool BrowserPluginBindingsInvoke(NPObject* np_obj, NPIdentifier name,
return false;
v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(value);
- return bindings->instance()->AddEventListener(event_name, function);
+ result->type = NPVariantType_Bool;
+ result->value.boolValue =
+ bindings->instance()->AddEventListener(event_name, function);
+ return true;
}
if (IdentifierIsBackMethod(name) && !arg_count) {
@@ -230,7 +233,10 @@ bool BrowserPluginBindingsInvoke(NPObject* np_obj, NPIdentifier name,
return false;
v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(value);
- return bindings->instance()->RemoveEventListener(event_name, function);
+ result->type = NPVariantType_Bool;
+ result->value.boolValue =
+ bindings->instance()->RemoveEventListener(event_name, function);
+ return true;
}
if (IdentifierIsStop(name) && !arg_count) {
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | content/renderer/browser_plugin/browser_plugin_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698