Simplify document title for Windows printing.

Simplify document title for Windows printing.
Some drivers can't handle long titles or control characters.

BUG=65469
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157715

[Vitaly Buka (NO REVIEWS), 2012-09-18 23:28:32]

Let's try to push to Canary and check if it's fix the issue.

[Timur Iskhodzhanov, 2012-09-19 10:49:07]

FYI, the first patchset fixes the issue for me;
Haven't tried the second one yet.

[Vitaly Buka (NO REVIEWS), 2012-09-19 18:26:25]

Please review.

[Albert Bodenhamer, 2012-09-19 18:37:10]

There's some thought that bad document titles might be affecting certain cloud
printers as well.  Should we apply similar filtering on cloud print submissions?

http://codereview.chromium.org/10941025/diff/7001/printing/backend/win_helper.cc
File printing/backend/win_helper.cc (right):

http://codereview.chromium.org/10941025/diff/7001/printing/backend/win_helper...
printing/backend/win_helper.cc:385: string16 SimplifyDocumentTitle(const
string16& title) {
Consider moving this into PrintBackend and doing the same filtering on other
platforms.  I don't see a reason to limit the filtering to Windows (I could
imagine other platforms having the same issue)

[Vitaly Buka (NO REVIEWS), 2012-09-20 00:17:37]

Done.

On 2012/09/19 18:37:10, Albert Bodenhamer wrote:
> There's some thought that bad document titles might be affecting certain cloud
> printers as well.  Should we apply similar filtering on cloud print
submissions?
> 
>
http://codereview.chromium.org/10941025/diff/7001/printing/backend/win_helper.cc
> File printing/backend/win_helper.cc (right):
> 
>
http://codereview.chromium.org/10941025/diff/7001/printing/backend/win_helper...
> printing/backend/win_helper.cc:385: string16 SimplifyDocumentTitle(const
> string16& title) {
> Consider moving this into PrintBackend and doing the same filtering on other
> platforms.  I don't see a reason to limit the filtering to Windows (I could
> imagine other platforms having the same issue)

[Albert Bodenhamer, 2012-09-20 00:25:20]

lgtm

With nits.

http://codereview.chromium.org/10941025/diff/11001/printing/backend/print_bac...
File printing/backend/print_backend.cc (right):

http://codereview.chromium.org/10941025/diff/11001/printing/backend/print_bac...
printing/backend/print_backend.cc:15: const int kMaxDocumentTitleLength = 25;
Is 25 long enough?  We can start with this for now.

http://codereview.chromium.org/10941025/diff/11001/printing/backend/print_bac...
File printing/backend/print_backend.h (right):

http://codereview.chromium.org/10941025/diff/11001/printing/backend/print_bac...
printing/backend/print_backend.h:96: // Simplify title to resolve issue with
some drivers on Windows.
nit: Change is no longer Win specific.

[Vitaly Buka (NO REVIEWS), 2012-09-20 00:28:44]

http://codereview.chromium.org/10941025/diff/11001/printing/backend/print_bac...
File printing/backend/print_backend.h (right):

http://codereview.chromium.org/10941025/diff/11001/printing/backend/print_bac...
printing/backend/print_backend.h:96: // Simplify title to resolve issue with
some drivers on Windows.
On 2012/09/20 00:25:20, Albert Bodenhamer wrote:
> nit: Change is no longer Win specific.

Done.

[commit-bot: I haz the power, 2012-09-20 01:20:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10941025/11013

[commit-bot: I haz the power, 2012-09-20 01:35:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10941025/22001

[commit-bot: I haz the power, 2012-09-20 05:58:44]

Change committed as 157715