Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: content/test/layout_browsertest.h

Issue 10941011: Rewrite layout_browsertests to use content_shell --dump-render-tree to execute layout tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/layout_browsertest.h
diff --git a/content/test/layout_browsertest.h b/content/test/layout_browsertest.h
index 00c12136e9bfacad4d59e11a9d8d602e211d2825..c4064660e799b41e2a7fdbd44de348093bab7d1e 100644
--- a/content/test/layout_browsertest.h
+++ b/content/test/layout_browsertest.h
@@ -8,6 +8,9 @@
class GURL;
class LayoutTestHttpServer;
+namespace content {
+class WebKitTestController;
+}
class InProcessBrowserLayoutTest : public content::ContentBrowserTest {
public:
@@ -26,33 +29,31 @@ class InProcessBrowserLayoutTest : public content::ContentBrowserTest {
virtual ~InProcessBrowserLayoutTest();
virtual void SetUpInProcessBrowserTestFixture() OVERRIDE;
+ virtual void SetUpOnMainThread() OVERRIDE;
+ virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE;
// Runs a layout test given its filename relative to the path given to the
// constructor.
void RunLayoutTest(const std::string& test_case_file_name);
// Runs a layout test using the HTTP test server. The second constructor must
// have been used.
void RunHttpLayoutTest(const std::string& test_case_file_name);
- void AddResourceForLayoutTest(const FilePath& parent_dir,
- const FilePath& resource_name);
private:
void RunLayoutTestInternal(const std::string& test_case_file_name,
const GURL& url);
- void WriteModifiedFile(const std::string& test_case_file_name,
- FilePath* test_path);
std::string SaveResults(const std::string& expected,
const std::string& actual);
- FilePath our_original_layout_test_dir_;
+ FilePath layout_test_dir_;
FilePath test_parent_dir_;
FilePath test_case_dir_;
- FilePath our_layout_test_temp_dir_;
FilePath rebase_result_dir_;
FilePath rebase_result_chromium_dir_;
FilePath rebase_result_win_dir_;
- ScopedTempDir scoped_temp_dir_;
int port_; // -2 means no port. -1 means random.
scoped_ptr<LayoutTestHttpServer> test_http_server_;
+ scoped_ptr<content::WebKitTestController> test_controller_;
+
DISALLOW_COPY_AND_ASSIGN(InProcessBrowserLayoutTest);
};

Powered by Google App Engine
This is Rietveld 408576698