Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3022)

Issue 10939033: Wait for resolving conflicts in merge-to-branch script. (Closed)

Created:
6 years, 12 months ago by ulan
Modified:
6 years, 12 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Wait for resolving conflicts in merge-to-branch script. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12560

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M tools/common-includes.sh View 1 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
PTAL
6 years, 12 months ago (2012-09-19 15:48:09 UTC) #1
Jakob Kummerow
6 years, 12 months ago (2012-09-19 16:29:24 UTC) #2
LGTM. Nice idea!

https://chromiumcodereview.appspot.com/10939033/diff/2001/tools/common-includ...
File tools/common-includes.sh (right):

https://chromiumcodereview.appspot.com/10939033/diff/2001/tools/common-includ...
tools/common-includes.sh:184: echo "Applying the patch failed. Either type
\"ABORT<Return>\" or \
nit: for readability, please insert a comma before the "or".

Powered by Google App Engine
This is Rietveld 408576698