Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 10939013: Improve the assembly code for power function with integer exponential on x64 (Closed)

Created:
8 years, 3 months ago by xqian
Modified:
8 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Improve the assembly code for power function with integer exponential on x64 The change removes one unused multiply and reschedules the shift, multiply and jump instructions to reduce stall. Experiment shows it improve about 20% performance on x64 for exponetials from about 100 to 2000. Committed: https://code.google.com/p/v8/source/detail?r=12535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/x64/code-stubs-x64.cc View 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
xqian
Hi, Yang, Kasper, Yuqiang and Vyacheslav This is a port for patch of issue 10916311. ...
8 years, 3 months ago (2012-09-18 06:35:07 UTC) #1
Yang
On 2012/09/18 06:35:07, xqian wrote: > Hi, Yang, Kasper, Yuqiang and Vyacheslav > > This ...
8 years, 3 months ago (2012-09-18 07:59:09 UTC) #2
xqian
8 years, 3 months ago (2012-09-18 10:02:30 UTC) #3
On 2012/09/18 07:59:09, Yang wrote:
> On 2012/09/18 06:35:07, xqian wrote:
> > Hi, Yang, Kasper, Yuqiang and Vyacheslav
> > 
> > This is a port for patch of issue 10916311. It can gain similar performance
> > improvement on x64. Would you please review it?
> > 
> > Thanks,
> > -Xi
> 
> LGTM. Landing.

Thank you!
-Xi

Powered by Google App Engine
This is Rietveld 408576698