base/i18n/bidi_line_iterator.cc - Issue 10939010: Cleanup: avoid foo ? true : false, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/i18n/bidi_line_iterator.cc

Issue 10939010: Cleanup: avoid foo ? true : false, part 1. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: rebase Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/i18n/bidi_line_iterator.cc

===================================================================

--- base/i18n/bidi_line_iterator.cc (revision 159076)

+++ base/i18n/bidi_line_iterator.cc (working copy)

@@ -32,7 +32,7 @@

ubidi_setPara(bidi_, text.data(), static_cast<int>(text.length()),

right_to_left ? UBIDI_DEFAULT_RTL : UBIDI_DEFAULT_LTR,

NULL, &error);

- return U_SUCCESS(error) ? true : false;

+ return (U_SUCCESS(error) == TRUE);

}

int BiDiLineIterator::CountRuns() {

« no previous file with comments | « no previous file | chrome/browser/component_updater/component_updater_service.cc » ('j') | no next file with comments »