Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issue 10939010: Cleanup: avoid foo ? true : false, part 1. (Closed)

Created:
8 years, 3 months ago by Lei Zhang
Modified:
8 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, James Su, gavinp+disk_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, msw+watch_chromium.org, darin-cc_chromium.org, pam+watch_chromium.org, erikwright+watch_chromium.org, alicet1, jshin+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Cleanup: avoid foo ? true : false, part 1. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159137

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -44 lines) Patch
M base/i18n/bidi_line_iterator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/quota_internals_types.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/common/gpu/media/h264_parser.cc View 1 6 chunks +8 lines, -8 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_web_contents_view_delegate_win.cc View 1 5 chunks +6 lines, -7 lines 0 comments Download
M gpu/demos/framework/pepper.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M media/audio/cross_process_notification_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_wtl/mainfrm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/convolver_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/win/ime_input.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas_skia.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_border.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_search.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
brettw: base, content, and chrome ben: gpu, media, skia, and ui
8 years, 3 months ago (2012-09-21 20:33:06 UTC) #1
brettw
base/content/chrome lgrm
8 years, 3 months ago (2012-09-22 22:52:35 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 2 months ago (2012-09-27 16:16:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10939010/39004
8 years, 2 months ago (2012-09-27 19:50:21 UTC) #4
commit-bot: I haz the power
Presubmit check for 10939010-39004 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-09-27 19:50:28 UTC) #5
brettw
lgtm
8 years, 2 months ago (2012-09-27 19:58:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10939010/39004
8 years, 2 months ago (2012-09-27 19:59:02 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-09-27 22:32:24 UTC) #8
Change committed as 159137

Powered by Google App Engine
This is Rietveld 408576698