Do not assume gclient is in the PATH.

Do not assume gclient is in the PATH.

Also specify the batch file on Windows. Python's subprocess is picky about that.

TBR=rogerta@chromium.org
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157337

[commit-bot: I haz the power, 2012-09-18 10:31:27]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[commit-bot: I haz the power, 2012-09-18 10:31:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10939008/1

[commit-bot: I haz the power, 2012-09-18 10:34:26]

Change committed as 157337

[Roger Tawa OOO till Jul 10th, 2012-09-18 13:02:15]

Lgtm
On Sep 17, 2012 9:01 PM, <maruel@chromium.org> wrote:

> Reviewers: Roger Tawa,
>
> Description:
> Do not assume gclient is in the PATH.
>
> Also specify the batch file on Windows. Python's subprocess is picky about
> that.
>
> R=rogerta@chromium.org
> BUG=
>
>
> Please review this at
https://codereview.chromium.**org/10939008/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/tools/depot_tools<http://svn.chromium.org/chrome/trunk/tools/depot_tools>
>
> Affected files:
>   M apply_issue.py
>
>
> Index: apply_issue.py
> diff --git a/apply_issue.py b/apply_issue.py
> index 3b3f1f4c1db22907a1b082cb293cce**875c33000e..**
> 8b50b37e50a53b76c5328e92512e7d**4463dd43c8 100755
> --- a/apply_issue.py
> +++ b/apply_issue.py
> @@ -22,6 +22,8 @@ import gclient_utils
>  import rietveld
>  import scm
>
> +BASE_DIR = os.path.dirname(os.path.**abspath(__file__))
> +
>
>  def main():
>    parser = optparse.OptionParser(**description=sys.modules[__**
> name__].__doc__)
> @@ -119,8 +121,11 @@ def main():
>            'A DEPS file was updated inside a gclient checkout, running
> gclient '
>            'sync.')
>        base_rev = 'BASE' if scm_type == 'svn' else 'HEAD'
> +      gclient_path = os.path.join(BASE_DIR, 'gclient')
> +      if sys.platform == 'win32':
> +        gclient_path += '.bat'
>        return subprocess.call(
> -          ['gclient', 'sync', '--revision', base_rev], cwd=gclient_root)
> +          [gclient_path, 'sync', '--revision', base_rev],
> cwd=gclient_root)
>    return 0
>
>
>
>
>