Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 10938019: Clean up: Use StringPrintf instead of string concatenation operator. (Closed)

Created:
8 years, 3 months ago by kmadhusu
Modified:
8 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Clean up: Use StringPrintf instead of string concatenation operator. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157606

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/browser/system_monitor/media_transfer_protocol_device_observer_chromeos.cc View 1 2 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kmadhusu
8 years, 3 months ago (2012-09-19 18:56:53 UTC) #1
Lei Zhang
lgtm http://codereview.chromium.org/10938019/diff/3001/chrome/browser/system_monitor/media_transfer_protocol_device_observer_chromeos.cc File chrome/browser/system_monitor/media_transfer_protocol_device_observer_chromeos.cc (right): http://codereview.chromium.org/10938019/diff/3001/chrome/browser/system_monitor/media_transfer_protocol_device_observer_chromeos.cc#newcode79 chrome/browser/system_monitor/media_transfer_protocol_device_observer_chromeos.cc:79: return base::StringPrintf("%s%s%s", Please format this function call correctly. ...
8 years, 3 months ago (2012-09-19 19:03:32 UTC) #2
kmadhusu
https://codereview.chromium.org/10938019/diff/3001/chrome/browser/system_monitor/media_transfer_protocol_device_observer_chromeos.cc File chrome/browser/system_monitor/media_transfer_protocol_device_observer_chromeos.cc (right): https://codereview.chromium.org/10938019/diff/3001/chrome/browser/system_monitor/media_transfer_protocol_device_observer_chromeos.cc#newcode79 chrome/browser/system_monitor/media_transfer_protocol_device_observer_chromeos.cc:79: return base::StringPrintf("%s%s%s", On 2012/09/19 19:03:32, Lei Zhang wrote: > ...
8 years, 3 months ago (2012-09-19 19:06:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10938019/7001
8 years, 3 months ago (2012-09-19 19:06:19 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 20:59:49 UTC) #5
Change committed as 157606

Powered by Google App Engine
This is Rietveld 408576698