build/android/pylib/android_commands.py - Issue 10938014: Android: uses a fifo rather than logcat for the test runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/android_commands.py

Issue 10938014: Android: uses a fifo rather than logcat for the test runner. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/android_commands.py

diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py

index 3e4daea3123646cb09653042132820b1be5219bb..e7a27f91228a2711679e0986d26466119a2272da 100644

--- a/build/android/pylib/android_commands.py

+++ b/build/android/pylib/android_commands.py

@@ -984,7 +984,7 @@ class AndroidCommands(object):

return pids

def FileExistsOnDevice(self, file_name):

- """Checks whether the given (regular) file exists on the device.

+ """Checks whether the given file exists on the device.

Args:

file_name: Full path of file to check.

@@ -994,7 +994,7 @@ class AndroidCommands(object):

"""

assert '"' not in file_name, 'file_name cannot contain double quotes'

status = self._adb.SendShellCommand(

- '\'test -f "%s"; echo $?\'' % (file_name))

+ '\'test -e "%s"; echo $?\'' % (file_name))

if 'test: not found' not in status:

return int(status) == 0