Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3622)

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.h

Issue 10938009: Views fuzzing for Aura and Windows (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Making windows-specific code conditional. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab_strip.h
diff --git a/chrome/browser/ui/views/tabs/tab_strip.h b/chrome/browser/ui/views/tabs/tab_strip.h
index bb2349cbb62c7d7c6bc4e46df6910e39fedb2a1f..623f6b0f1e4a7ae0889974eb97c46537ac7e1065 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.h
+++ b/chrome/browser/ui/views/tabs/tab_strip.h
@@ -204,8 +204,8 @@ class TabStrip : public views::View,
virtual void OnDragExited() OVERRIDE;
virtual int OnPerformDrop(const ui::DropTargetEvent& event) OVERRIDE;
virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
- virtual views::View* GetEventHandlerForPoint(
- const gfx::Point& point) OVERRIDE;
+ virtual views::View* GetEventHandler(const gfx::Rect& rect, EventType type)
+ OVERRIDE;
protected:
// Horizontal gap between mini and non-mini-tabs.
@@ -452,6 +452,10 @@ class TabStrip : public views::View,
// hit-test region of the specified Tab.
bool IsPointInTab(Tab* tab, const gfx::Point& point_in_tabstrip_coords);
+ // Returns true if the specified rect in TabStrip coords intersects the
+ // hit-test region of the specified Tab.
+ bool IsRectInTab(Tab* tab, const gfx::Rect& rect_in_tabstrip_coords);
+
// -- Touch Layout ----------------------------------------------------------
// Returns the position normal tabs start at.
@@ -459,12 +463,22 @@ class TabStrip : public views::View,
// Returns the tab to use for event handling. This uses FindTabForEventFrom()
// to do the actual searching.
+ // TODO: Deprecate
Tab* FindTabForEvent(const gfx::Point& point);
+ // Returns the tab to use for event handling. This uses FindTabForEventFrom()
+ // to do the actual searching.
+ Tab* FindTabForEvent(const gfx::Rect& rect);
+
// Returns the tab to use for event handling starting at index |start| and
// iterating by |delta|.
+ // TODO: Deprecate
Tab* FindTabForEventFrom(const gfx::Point& point, int start, int delta);
+ // Returns the tab to use for event handling starting at index |start| and
+ // iterating by |delta|.
+ Tab* FindTabForEventFrom(const gfx::Rect& rect, int start, int delta);
+
// Returns the x-coordinates of the tabs.
std::vector<int> GetTabXCoordinates();

Powered by Google App Engine
This is Rietveld 408576698