chrome/browser/ui/tabs/tab_strip_model.cc - Issue 10937028: Do not discard selected tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_model.cc

Issue 10937028: Do not discard selected tab (Closed) Base URL: http://git.chromium.org/chromium/src.git@new

Patch Set: handle active tab Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tabs/tab_strip_model.cc

diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc

index 2c63cf8a8ec575109adfc6a865474344b97bfe44..9b87c52b5949bbe7b82c9ba09c9b88a86db70d97 100644

--- a/chrome/browser/ui/tabs/tab_strip_model.cc

+++ b/chrome/browser/ui/tabs/tab_strip_model.cc

@@ -205,6 +205,10 @@ void TabStripModel::ReplaceNavigationControllerAt(

TabContents* TabStripModel::DiscardTabContentsAt(int index) {

DCHECK(ContainsIndex(index));

+ // Do not discard active tab.

+ if (active_index() == index)

+ return NULL;

TabContents* null_contents = TabContents::Factory::CreateTabContents(

WebContents::Create(profile(),

NULL /* site_instance */,