src/ia32/code-stubs-ia32.cc - Issue 10937013: Fixed minus zero test (fixes v8:2133).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 10937013: Fixed minus zero test (fixes v8:2133). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed tab. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/code-stubs-ia32.cc

diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc

index 96d45d319eeb8c4e13870e3b7ee636a9a67648a8..65a49349360f96963e6fab8197dbf565febc59e9 100644

--- a/src/ia32/code-stubs-ia32.cc

+++ b/src/ia32/code-stubs-ia32.cc

@@ -1793,9 +1793,10 @@ void BinaryOpStub::GenerateInt32Stub(MacroAssembler* masm) {

if (result_type_ <= BinaryOpIC::INT32) {

__ cvttsd2si(ecx, Operand(xmm0));

__ cvtsi2sd(xmm2, ecx);

- __ ucomisd(xmm0, xmm2);

- __ j(not_zero, &not_int32);

- __ j(carry, &not_int32);

+ __ pcmpeqd(xmm2, xmm0);

+ __ movmskpd(ecx, xmm2);

+ __ test(ecx, Immediate(1));

+ __ j(zero, &not_int32);

}

GenerateHeapResultAllocation(masm, &call_runtime);

__ movdbl(FieldOperand(eax, HeapNumber::kValueOffset), xmm0);

« no previous file with comments | « src/ia32/assembler-ia32.cc ('k') | src/ia32/disasm-ia32.cc » ('j') | no next file with comments »