Issue 10937013: Fixed minus zero test (fixes v8:2133).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10937013: Fixed minus zero test (fixes v8:2133). (Closed)

Created:
8 years, 3 months ago by Massi

Modified:
8 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed minus zero test (fixes v8:2133). BUG=v8:2133 Committed: https://code.google.com/p/v8/source/detail?r=12548

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added pcmpeqd instruction to the disassembler. #

Patch Set 3 : Removed tab. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -22 lines)			Patch
M	src/ia32/assembler-ia32.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/ia32/disasm-ia32.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A +	test/mjsunit/deopt-minus-zero.js	View	1 2	1 chunk	+22 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Looks good so far, but please add disassembler support for the newly added instruction. https://chromiumcodereview.appspot.com/10937013/diff/1/test/mjsunit/deopt-minus-zero.js ...

8 years, 3 months ago (2012-09-18 13:56:09 UTC) #2

lgtm

Expand Messages | Collapse Messages