Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10933137: Media Galleries: Change the media gallery name to be a JSON value with the name and pref id. (Closed)

Created:
8 years, 3 months ago by Lei Zhang
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Media Galleries: Change the media gallery name to be a JSON value with the name and pref id. BUG=144535 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157277

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -17 lines) Patch
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 1 2 2 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/media_gallery/media_file_system_registry.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/media_gallery/media_file_system_registry.cc View 1 5 chunks +48 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
I may need to fix up all the tests, but I don't expect this code ...
8 years, 3 months ago (2012-09-17 21:50:25 UTC) #1
Lei Zhang
Tests seem fine. See patch set 2.
8 years, 3 months ago (2012-09-17 22:55:54 UTC) #2
Lei Zhang
NOTREACHED() in patch set 3.
8 years, 3 months ago (2012-09-17 23:34:42 UTC) #3
vandebo (ex-Chrome)
LGTM
8 years, 3 months ago (2012-09-17 23:40:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10933137/11001
8 years, 3 months ago (2012-09-17 23:43:07 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-17 23:45:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10933137/11001
8 years, 3 months ago (2012-09-18 01:02:50 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 02:07:35 UTC) #8
Change committed as 157277

Powered by Google App Engine
This is Rietveld 408576698