Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10933129: Add RenderText::SetFont() function to simplify some call sites. (Closed)

Created:
8 years, 3 months ago by Alexei Svitkine (slow)
Modified:
8 years, 3 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Add RenderText::SetFont() function to simplify some call sites. BUG=none TEST=existing unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157365

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/gfx/canvas_skia.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/render_text.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 3 chunks +10 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Alexei Svitkine (slow)
8 years, 3 months ago (2012-09-17 19:42:38 UTC) #1
msw
LGTM, but maybe add a simple test for sanity?
8 years, 3 months ago (2012-09-17 20:03:47 UTC) #2
Alexei Svitkine (slow)
+sky for OWNERS Added the unit test.
8 years, 3 months ago (2012-09-17 20:26:12 UTC) #3
sky
LGTM
8 years, 3 months ago (2012-09-17 20:47:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10933129/10001
8 years, 3 months ago (2012-09-17 21:17:57 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-18 00:26:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10933129/10001
8 years, 3 months ago (2012-09-18 00:32:19 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-18 03:58:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10933129/10001
8 years, 3 months ago (2012-09-18 13:28:05 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 16:00:43 UTC) #10 
Change committed as 157365

Powered by Google App Engine
This is Rietveld 408576698