Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10933091: Enable a minimal content/ build on iOS (Closed)

Created:
8 years, 3 months ago by stuartmorgan
Modified:
8 years, 3 months ago
Reviewers:
Nico, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@rohits-image-change
Visibility:
Public.

Description

Enable a minimal content/ build on iOS This removes some files from the already-upstreamed iOS content/ gyp support in order to get a minimal target building while the remaining content/ changes are upstreamed. Minor ifdefing is necessary in a few files in order to build them on iOS; these are included since they are core files without which it's very difficult to bring up a build at all. Adds one new class to the ui/ build since it's needed by the content/ code that is now built. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157421

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -21 lines) Patch
M build/all.gyp View 2 chunks +1 line, -1 line 0 comments Download
M content/content_app.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +2 lines, -5 lines 0 comments Download
M content/content_common.gypi View 3 chunks +2 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 5 chunks +5 lines, -8 lines 0 comments Download
M content/public/app/content_main_delegate.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M content/public/common/content_client.cc View 2 chunks +8 lines, -1 line 0 comments Download
M content/public/test/unittest_test_suite.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/test/unittest_test_suite.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/test/test_content_browser_client.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/ui.gyp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
stuartmorgan
Nico: just for ui/ OWNERS to compile one new class for iOS (lots more ui/ ...
8 years, 3 months ago (2012-09-14 12:42:20 UTC) #1
Nico
ui.gyp lgtm
8 years, 3 months ago (2012-09-14 12:53:25 UTC) #2
jam
lgtm
8 years, 3 months ago (2012-09-17 22:19:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10933091/4001
8 years, 3 months ago (2012-09-18 14:04:34 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-18 18:15:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10933091/4001
8 years, 3 months ago (2012-09-18 20:29:54 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 21:36:33 UTC) #7
Change committed as 157421

Powered by Google App Engine
This is Rietveld 408576698