Issue 10933084: Fix device broadcast DCHECK.

Issue 10933084: Fix device broadcast DCHECK. (Closed)

Created:
8 years, 3 months ago by vandebo (ex-Chrome)

Modified:
8 years, 3 months ago

Reviewers:
piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, tommi (sloooow) - chröme

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix device broadcast DCHECK. Inserting/removing a USB device will trip this DCHECK. BUG=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156726

Patch Set 2 : Address comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	content/browser/system_message_window_win.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

piman

LGTM+nit https://codereview.chromium.org/10933084/diff/1/content/browser/system_message_window_win.cc File content/browser/system_message_window_win.cc (right): https://codereview.chromium.org/10933084/diff/1/content/browser/system_message_window_win.cc#newcode115 content/browser/system_message_window_win.cc:115: static_cast<DWORD>(DBT_DEVTYP_DEVICEINTERFACE)) { nit: Is the static_cast needed anymore? ...

8 years, 3 months ago (2012-09-14 00:37:44 UTC) #2

vandebo (ex-Chrome)

https://codereview.chromium.org/10933084/diff/1/content/browser/system_message_window_win.cc File content/browser/system_message_window_win.cc (right): https://codereview.chromium.org/10933084/diff/1/content/browser/system_message_window_win.cc#newcode115 content/browser/system_message_window_win.cc:115: static_cast<DWORD>(DBT_DEVTYP_DEVICEINTERFACE)) { On 2012/09/14 00:37:44, piman wrote: > nit: ...

8 years, 3 months ago (2012-09-14 00:43:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10933084/4001

8 years, 3 months ago (2012-09-14 00:43:54 UTC) #4

Change committed as 156726

Expand Messages | Collapse Messages