Issue 10933083: Remove deprecated gfx::Image::operator NSImage*().

Issue 10933083: Remove deprecated gfx::Image::operator NSImage*(). (Closed)

Created:
8 years, 3 months ago by Robert Sesek

Modified:
8 years, 3 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews, asanka, groby+watch_chromium.org, jam, browser-components-watch_chromium.org, Randy Smith (Not in Mondays), dcheng, Dmitry Titov, joi+watch-content_chromium.org, rsesek+watch_chromium.org, jennb, darin-cc_chromium.org, jianli, gbillock+watch_chromium.org, smckay+watch_chromium.org, James Su, rouslan+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove deprecated gfx::Image::operator NSImage*(). BUG=58030 TEST=Compiles. TBR=rohitrao@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156820

Patch Set 1 #

Total comments: 6

Patch Set 2 : Comments and merge #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -89 lines)			Patch
M	chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/themes/theme_service_mac.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_item_controller.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_item_mac.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_show_all_button.mm	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_started_animation_mac.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_util_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/history_menu_bridge.mm	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/hover_image_button_unittest.mm	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/hung_renderer_controller.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/infobars/infobar_controller.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/page_info_bubble_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/speech_recognition_window_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tab_contents/sad_tab_view.mm	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabpose_window.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/throbber_view_unittest.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/web_intent_sheet_controller.mm	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/website_settings_bubble_controller.mm	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm	View	1	1 chunk	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_window_controller_cocoa.mm	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/tests/ui_gfx_image_unittest.mm	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_drag_source_mac.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/gfx/image/image.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	ui/gfx/image/image.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	ui/gfx/image/image_mac_unittest.mm	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	webkit/glue/webcursor_mac.mm	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

lgtm Definitely better this way. operator* was letting us do some weird things. https://codereview.chromium.org/10933083/diff/1/chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm File ...

8 years, 3 months ago (2012-09-14 00:11:20 UTC) #2

Robert Sesek

https://codereview.chromium.org/10933083/diff/1/chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm File chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm (left): https://codereview.chromium.org/10933083/diff/1/chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm#oldcode187 chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm:187: DCHECK(infoIcon); On 2012/09/14 00:11:21, rohitrao wrote: > Why no ...

8 years, 3 months ago (2012-09-14 14:37:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10933083/38

8 years, 3 months ago (2012-09-14 14:39:44 UTC) #4

Change committed as 156820

Expand Messages | Collapse Messages