Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 10933062: File manager: add a missing JS (file_manager_command.js) to the main_script.js (Closed)

Created:
8 years, 3 months ago by hshi1
Modified:
8 years, 3 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

File manager: add a missing JS file (file_manager_commands.js) to the main_script.js Fixes an undefined object error. BUG=148780 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/file_manager/js/main_scripts.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hshi1
PTAL. I have no idea why it works (it looks like the entire main_script.js is ...
8 years, 3 months ago (2012-09-13 02:03:27 UTC) #1
Vladislav Kaznacheev
lgtm
8 years, 3 months ago (2012-09-13 07:54:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/10933062/1
8 years, 3 months ago (2012-09-13 07:54:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/10933062/1
8 years, 3 months ago (2012-09-13 10:21:58 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s)
8 years, 3 months ago (2012-09-13 11:50:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/10933062/1
8 years, 3 months ago (2012-09-13 12:02:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/10933062/1
8 years, 3 months ago (2012-09-13 12:50:48 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 12:59:36 UTC) #8
Change committed as 156533

Powered by Google App Engine
This is Rietveld 408576698