Use base::TimeDelta in SafeBrowsingProtocolManager.

Use base::TimeDelta in SafeBrowsingProtocolManager.

There were a fair number of manual conversions from seconds and milliseconds, and this seemed safer.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156874

[mattm, 2012-09-12 20:00:03]

http://codereview.chromium.org/10933047/diff/2003/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/protocol_manager.cc (right):

http://codereview.chromium.org/10933047/diff/2003/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/protocol_manager.cc:349: if (next_update_interval >
base::TimeDelta::FromSeconds(0)) {
These base::TimeDelta::FromSeconds(0)s could also just be written as
base::TimeDelta(), unless you think that makes it harder to read.

http://codereview.chromium.org/10933047/diff/2003/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/protocol_manager.cc:437: DCHECK(interval >
base::TimeDelta::FromSeconds(0));
Do the DCHECK_GE & friends not work with TimeDeltas?

(also this should be >=)

http://codereview.chromium.org/10933047/diff/2003/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/protocol_manager_unittest.cc (right):

http://codereview.chromium.org/10933047/diff/2003/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/protocol_manager_unittest.cc:26:
DCHECK(pm.back_off_fuzz_ >= 0.0 && pm.back_off_fuzz_ <= 1.0);
While you're here you could change this to some ASSERT_ tests instead of
dchecking.

[cbentzel, 2012-09-12 21:32:47]

http://codereview.chromium.org/10933047/diff/2003/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/protocol_manager.cc (right):

http://codereview.chromium.org/10933047/diff/2003/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/protocol_manager.cc:349: if (next_update_interval >
base::TimeDelta::FromSeconds(0)) {
On 2012/09/12 20:00:03, mattm wrote:
> These base::TimeDelta::FromSeconds(0)s could also just be written as
> base::TimeDelta(), unless you think that makes it harder to read.

Done.

http://codereview.chromium.org/10933047/diff/2003/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/protocol_manager.cc:437: DCHECK(interval >
base::TimeDelta::FromSeconds(0));
On 2012/09/12 20:00:03, mattm wrote:
> Do the DCHECK_GE & friends not work with TimeDeltas?
> 
> (also this should be >=)

Thanks for the catch.

They don't work because operator<< isn't defined.

http://codereview.chromium.org/10933047/diff/2003/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/protocol_manager_unittest.cc (right):

http://codereview.chromium.org/10933047/diff/2003/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/protocol_manager_unittest.cc:26:
DCHECK(pm.back_off_fuzz_ >= 0.0 && pm.back_off_fuzz_ <= 1.0);
On 2012/09/12 20:00:03, mattm wrote:
> While you're here you could change this to some ASSERT_ tests instead of
> dchecking.

This was the only DCHECK in the file -> converted to ASSERT_TRUE

[mattm, 2012-09-12 21:46:21]

lgtm

[commit-bot: I haz the power, 2012-09-14 18:29:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cbentzel@chromium.org/10933047/9002

[commit-bot: I haz the power, 2012-09-14 20:26:56]

Change committed as 156874