Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10933046: Cleanup: Replace LoadInstanceFieldInstr with LoadVMFieldInstr. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 12267)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -947,24 +947,6 @@
}
-LocationSummary* LoadInstanceFieldInstr::MakeLocationSummary() const {
- // TODO(fschneider): For this instruction the input register may be
- // reused for the result (but is not required to) because the input
- // is not used after the result is defined. We should consider adding
- // this information to the input policy.
- return LocationSummary::Make(1,
- Location::RequiresRegister(),
- LocationSummary::kNoCall);
-}
-
-
-void LoadInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
- Register instance_reg = locs()->in(0).reg();
- Register result_reg = locs()->out().reg();
- __ movl(result_reg, FieldAddress(instance_reg, field().Offset()));
-}
-
-
LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary() const {
const intptr_t kNumInputs = 2;
const intptr_t num_temps = 0;

Powered by Google App Engine
This is Rietveld 408576698