runtime/vm/flow_graph_builder.cc - Issue 10933046: Cleanup: Replace LoadInstanceFieldInstr with LoadVMFieldInstr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10933046: Cleanup: Replace LoadInstanceFieldInstr with LoadVMFieldInstr. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_builder.cc

===================================================================

--- runtime/vm/flow_graph_builder.cc (revision 12267)

+++ runtime/vm/flow_graph_builder.cc (working copy)

@@ -2131,8 +2131,10 @@

ValueGraphVisitor for_instance(owner(), temp_index());

node->instance()->Visit(&for_instance);

Append(for_instance);

- LoadInstanceFieldInstr* load = new LoadInstanceFieldInstr(

- node->field(), for_instance.value());

+ LoadVMFieldInstr* load = new LoadVMFieldInstr(

srdjan 2012/09/12 17:22:34 Name is not good, since VM field denotes a field t

Florian Schneider 2012/09/12 17:31:16 Done.

+ for_instance.value(),

+ node->field().Offset(),

+ AbstractType::ZoneHandle(node->field().type()));

ReturnDefinition(load);

}

« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »