Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10933044: Move chrome/browser/plugin_* to chrome/browser/plugins/ (Closed)

Created:
8 years, 3 months ago by ibraaaa
Modified:
8 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, MAD, mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, nkostylev+watch_chromium.org, stuartmorgan+watch_chromium.org, tfarina, Ilya Sherman, kkania, Avi (use Gerrit), Aaron Boodman, rginda+watch_chromium.org, robertshield, oshima+watch_chromium.org, ajwong+watch_chromium.org, darin-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, jar (doing other things)
Base URL:
http://git.chromium.org/chromium/src.git@remove_plugin_group
Visibility:
Public.

Description

Move chrome/browser/plugin_* to chrome/browser/plugins/ TBR=jhawkins@chromium.org BUG=124396 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157834

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : +OWNERS file #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -3624 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_service_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/npapi_flash_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/pepper_flash_settings_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/plugin_data_remover_helper.h View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/plugin_data_remover_helper.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/plugin_finder.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/plugin_finder.cc View 1 1 chunk +0 lines, -299 lines 0 comments Download
D chrome/browser/plugin_finder_unittest.cc View 1 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/plugin_infobar_delegates.h View 1 chunk +0 lines, -202 lines 0 comments Download
D chrome/browser/plugin_infobar_delegates.cc View 1 1 chunk +0 lines, -491 lines 0 comments Download
D chrome/browser/plugin_installer.h View 1 1 chunk +0 lines, -128 lines 0 comments Download
D chrome/browser/plugin_installer.cc View 1 2 3 1 chunk +0 lines, -264 lines 0 comments Download
D chrome/browser/plugin_installer_observer.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/plugin_installer_observer.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/plugin_installer_unittest.cc View 1 2 3 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/plugin_observer.h View 1 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/plugin_observer.cc View 1 1 chunk +0 lines, -338 lines 0 comments Download
D chrome/browser/plugin_prefs.h View 1 1 chunk +0 lines, -204 lines 0 comments Download
D chrome/browser/plugin_prefs.cc View 1 2 3 1 chunk +0 lines, -663 lines 0 comments Download
D chrome/browser/plugin_prefs_factory.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/plugin_prefs_factory.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/browser/plugin_prefs_unittest.cc View 1 1 chunk +0 lines, -256 lines 0 comments Download
D chrome/browser/plugin_status_pref_setter.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/plugin_status_pref_setter.cc View 1 chunk +0 lines, -71 lines 0 comments Download
A + chrome/browser/plugins/OWNERS View 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/plugins/plugin_data_remover_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/plugins/plugin_data_remover_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/plugins/plugin_finder.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/plugins/plugin_finder.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/plugins/plugin_finder_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/plugins/plugin_infobar_delegates.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/plugins/plugin_infobar_delegates.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/plugins/plugin_installer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/plugins/plugin_installer.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/plugins/plugin_installer_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/plugins/plugin_installer_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/plugins/plugin_installer_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/plugins/plugin_observer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/plugins/plugin_observer.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/plugins/plugin_prefs.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/plugins/plugin_prefs.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/plugins/plugin_prefs_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/plugins/plugin_prefs_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/plugins/plugin_prefs_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/plugins/plugin_status_pref_setter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/plugins/plugin_status_pref_setter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/plugin_info_message_filter.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/pack_extension_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/nacl_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +20 lines, -20 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ibraaaa
8 years, 3 months ago (2012-09-12 10:48:58 UTC) #1
Bernhard Bauer
LGTM!
8 years, 3 months ago (2012-09-17 15:06:41 UTC) #2
ibraaaa
Hi John, Can I have an OWNERS review for this CL?
8 years, 3 months ago (2012-09-17 16:41:09 UTC) #3
jam
On 2012/09/17 16:41:09, ibraaaa wrote: > Hi John, > > Can I have an OWNERS ...
8 years, 3 months ago (2012-09-17 19:43:48 UTC) #4
ibraaaa
I have redone this on the origin, can you take another look?
8 years, 3 months ago (2012-09-18 18:12:06 UTC) #5
Bernhard Bauer
Still lgtm. In general, trivial mass-changes like these can be TBR'ed to the respective OWNERS.
8 years, 3 months ago (2012-09-20 16:57:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/10933044/6003
8 years, 3 months ago (2012-09-20 17:44:51 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/browser/chrome_browser_main.cc: While running patch -p1 --forward --force; patching file chrome/browser/chrome_browser_main.cc ...
8 years, 3 months ago (2012-09-20 17:45:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/10933044/22001
8 years, 3 months ago (2012-09-20 17:48:19 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 20:53:22 UTC) #10 
Change committed as 157834

Powered by Google App Engine
This is Rietveld 408576698