runtime/vm/intermediate_language_ia32.cc - Issue 10933043: Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10933043: Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

===================================================================

--- runtime/vm/intermediate_language_ia32.cc (revision 12244)

+++ runtime/vm/intermediate_language_ia32.cc (working copy)

@@ -1008,7 +1008,7 @@

void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

- if (this->value()->NeedsStoreBuffer()) {

+ if (this->value()->NeedsStoreBuffer() && may_need_store_barrier()) {

__ StoreIntoObject(instance_reg,

FieldAddress(instance_reg, field().Offset()), value_reg);

} else {

« runtime/vm/intermediate_language.h ('K') | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »