Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10933043: Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 12253)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -1956,7 +1956,7 @@
Token::kSET,
arguments,
Array::ZoneHandle(),
- 1); // Checked arg count.
+ 2); // Checked arg count.
ReturnDefinition(call);
}
@@ -1973,7 +1973,7 @@
Token::kSET,
arguments,
Array::ZoneHandle(),
- 1)); // Checked argument count.
+ 2)); // Checked argument count.
ReturnDefinition(BuildLoadExprTemp());
}
@@ -2154,8 +2154,9 @@
type,
dst_name);
}
+ const bool kEmitStoreBarrier = true;
StoreInstanceFieldInstr* store = new StoreInstanceFieldInstr(
- node->field(), for_instance.value(), store_value);
+ node->field(), for_instance.value(), store_value, kEmitStoreBarrier);
ReturnDefinition(store);
}
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698