Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 10933043: Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 1008 matching lines...) Expand 10 before | Expand all | Expand 10 after
1019 summary->set_in(1, 1019 summary->set_in(1,
1020 value()->NeedsStoreBuffer() ? Location::WritableRegister() 1020 value()->NeedsStoreBuffer() ? Location::WritableRegister()
1021 : Location::RequiresRegister()); 1021 : Location::RequiresRegister());
1022 return summary; 1022 return summary;
1023 } 1023 }
1024 1024
1025 1025
1026 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 1026 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
1027 Register instance_reg = locs()->in(0).reg(); 1027 Register instance_reg = locs()->in(0).reg();
1028 Register value_reg = locs()->in(1).reg(); 1028 Register value_reg = locs()->in(1).reg();
1029 if (this->value()->NeedsStoreBuffer()) { 1029 if (this->value()->NeedsStoreBuffer() && may_need_store_barrier()) {
1030 __ StoreIntoObject(instance_reg, 1030 __ StoreIntoObject(instance_reg,
1031 FieldAddress(instance_reg, field().Offset()), value_reg); 1031 FieldAddress(instance_reg, field().Offset()), value_reg);
1032 } else { 1032 } else {
1033 __ StoreIntoObjectNoBarrier(instance_reg, 1033 __ StoreIntoObjectNoBarrier(instance_reg,
1034 FieldAddress(instance_reg, field().Offset()), value_reg); 1034 FieldAddress(instance_reg, field().Offset()), value_reg);
1035 } 1035 }
1036 } 1036 }
1037 1037
1038 1038
1039 LocationSummary* LoadStaticFieldInstr::MakeLocationSummary() const { 1039 LocationSummary* LoadStaticFieldInstr::MakeLocationSummary() const {
(...skipping 1291 matching lines...) Expand 10 before | Expand all | Expand 10 after
2331 __ j(ABOVE_EQUAL, deopt); 2331 __ j(ABOVE_EQUAL, deopt);
2332 } 2332 }
2333 } 2333 }
2334 2334
2335 2335
2336 } // namespace dart 2336 } // namespace dart
2337 2337
2338 #undef __ 2338 #undef __
2339 2339
2340 #endif // defined TARGET_ARCH_X64 2340 #endif // defined TARGET_ARCH_X64
OLDNEW
« runtime/vm/intermediate_language.h ('K') | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698