Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10933043: Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 990 matching lines...) Expand 10 before | Expand all | Expand 10 after
1001 summary->set_in(1, 1001 summary->set_in(1,
1002 value()->NeedsStoreBuffer() ? Location::WritableRegister() 1002 value()->NeedsStoreBuffer() ? Location::WritableRegister()
1003 : Location::RequiresRegister()); 1003 : Location::RequiresRegister());
1004 return summary; 1004 return summary;
1005 } 1005 }
1006 1006
1007 1007
1008 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 1008 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
1009 Register instance_reg = locs()->in(0).reg(); 1009 Register instance_reg = locs()->in(0).reg();
1010 Register value_reg = locs()->in(1).reg(); 1010 Register value_reg = locs()->in(1).reg();
1011 if (this->value()->NeedsStoreBuffer()) { 1011 if (this->value()->NeedsStoreBuffer() && may_need_store_barrier()) {
1012 __ StoreIntoObject(instance_reg, 1012 __ StoreIntoObject(instance_reg,
1013 FieldAddress(instance_reg, field().Offset()), value_reg); 1013 FieldAddress(instance_reg, field().Offset()), value_reg);
1014 } else { 1014 } else {
1015 __ StoreIntoObjectNoBarrier(instance_reg, 1015 __ StoreIntoObjectNoBarrier(instance_reg,
1016 FieldAddress(instance_reg, field().Offset()), value_reg); 1016 FieldAddress(instance_reg, field().Offset()), value_reg);
1017 } 1017 }
1018 } 1018 }
1019 1019
1020 1020
1021 LocationSummary* LoadStaticFieldInstr::MakeLocationSummary() const { 1021 LocationSummary* LoadStaticFieldInstr::MakeLocationSummary() const {
(...skipping 1284 matching lines...) Expand 10 before | Expand all | Expand 10 after
2306 __ j(ABOVE_EQUAL, deopt); 2306 __ j(ABOVE_EQUAL, deopt);
2307 } 2307 }
2308 } 2308 }
2309 2309
2310 2310
2311 } // namespace dart 2311 } // namespace dart
2312 2312
2313 #undef __ 2313 #undef __
2314 2314
2315 #endif // defined TARGET_ARCH_X64 2315 #endif // defined TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698