Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 10933043: Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 947 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 summary->set_in(1, 958 summary->set_in(1,
959 value()->NeedsStoreBuffer() ? Location::WritableRegister() 959 value()->NeedsStoreBuffer() ? Location::WritableRegister()
960 : Location::RequiresRegister()); 960 : Location::RequiresRegister());
961 return summary; 961 return summary;
962 } 962 }
963 963
964 964
965 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 965 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
966 Register instance_reg = locs()->in(0).reg(); 966 Register instance_reg = locs()->in(0).reg();
967 Register value_reg = locs()->in(1).reg(); 967 Register value_reg = locs()->in(1).reg();
968 if (this->value()->NeedsStoreBuffer()) { 968 if (this->value()->NeedsStoreBuffer() && emit_store_barrier()) {
969 __ StoreIntoObject(instance_reg, 969 __ StoreIntoObject(instance_reg,
970 FieldAddress(instance_reg, field().Offset()), value_reg); 970 FieldAddress(instance_reg, field().Offset()), value_reg);
971 } else { 971 } else {
972 __ StoreIntoObjectNoBarrier(instance_reg, 972 __ StoreIntoObjectNoBarrier(instance_reg,
973 FieldAddress(instance_reg, field().Offset()), value_reg); 973 FieldAddress(instance_reg, field().Offset()), value_reg);
974 } 974 }
975 } 975 }
976 976
977 977
978 LocationSummary* LoadStaticFieldInstr::MakeLocationSummary() const { 978 LocationSummary* LoadStaticFieldInstr::MakeLocationSummary() const {
(...skipping 1291 matching lines...) Expand 10 before | Expand all | Expand 10 after
2270 __ j(ABOVE_EQUAL, deopt); 2270 __ j(ABOVE_EQUAL, deopt);
2271 } 2271 }
2272 } 2272 }
2273 2273
2274 2274
2275 } // namespace dart 2275 } // namespace dart
2276 2276
2277 #undef __ 2277 #undef __
2278 2278
2279 #endif // defined TARGET_ARCH_X64 2279 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698