Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 10933042: Call TSF's SetFocus iff the current focused document manager is expected ones (Closed)

Created:
8 years, 3 months ago by Yohei Yukawa
Modified:
8 years, 3 months ago
Reviewers:
sky, Seigo Nonaka
CC:
chromium-reviews, tfarina, James Su, chrome-tsf_google.com, cpu_(ooo_6.6-7.5)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

This patch set introduces a new utility method named "IsFocused" and calls TSF's SetFocus if and only if the current focused document manager is expected ones. Background: Despite that TsfBridge is responsible for managing IME on/off state only for content area, TsfBridge::EnableIME and TsfBridge::DisableIME will be called even when other UI components such as OmniBox have input focus. In this case, we should not call TSF's SetFocus because it makes TSF confused. BUG=141606 TEST=Manually tested on Windows 8 RTM with Metro mode. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156343

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M ui/base/win/tsf_bridge.cc View 1 2 chunks +28 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yohei Yukawa
8 years, 3 months ago (2012-09-12 13:41:45 UTC) #1
Seigo Nonaka
lgtm
8 years, 3 months ago (2012-09-12 13:43:48 UTC) #2
Yohei Yukawa
Adding sky@ as an owner of ui/. Thanks!
8 years, 3 months ago (2012-09-12 13:45:47 UTC) #3
sky
LGTM
8 years, 3 months ago (2012-09-12 14:45:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/10933042/1003
8 years, 3 months ago (2012-09-12 15:39:09 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-12 18:54:11 UTC) #6
Change committed as 156343

Powered by Google App Engine
This is Rietveld 408576698