runtime/vm/intrinsifier_ia32.cc - Issue 10933039: Make int an abstract class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 10933039: Make int an abstract class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Now with correct base. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intrinsifier_ia32.cc

diff --git a/runtime/vm/intrinsifier_ia32.cc b/runtime/vm/intrinsifier_ia32.cc

index fa1620561558faa4290270f8f7472abd2588a7c6..234afb6b5ea899122b7d97e354c57a9d0d4543b4 100644

--- a/runtime/vm/intrinsifier_ia32.cc

+++ b/runtime/vm/intrinsifier_ia32.cc

@@ -215,7 +215,7 @@ bool Intrinsifier::Array_setIndexed(Assembler* assembler) {

// Check for int and num.

__ testl(EDI, Immediate(kSmiTagMask)); // Value is Smi?

__ j(NOT_ZERO, &fall_through, Assembler::kNearJump); // Non-smi value.

- __ CompareObject(EAX, Type::ZoneHandle(Type::IntInterface()));

+ __ CompareObject(EAX, Type::ZoneHandle(Type::IntType()));

__ j(EQUAL, &checked_ok, Assembler::kNearJump);

__ CompareObject(EAX, Type::ZoneHandle(Type::Number()));

__ j(NOT_EQUAL, &fall_through, Assembler::kNearJump);