Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 10933039: Make int an abstract class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Now with correct base. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/core/int.dart ('k') | runtime/vm/dart_api_message.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
diff --git a/runtime/vm/class_finalizer.cc b/runtime/vm/class_finalizer.cc
index dea87135de002b5eab88de2d093f6b2efe1b6f0f..a3eb6aef8fce92b2841b2eb2d0c33366a4e002c3 100644
--- a/runtime/vm/class_finalizer.cc
+++ b/runtime/vm/class_finalizer.cc
@@ -301,7 +301,8 @@ void ClassFinalizer::ResolveSuperType(const Class& cls) {
break;
default:
// Special case: classes for which we don't have a known class id.
- if (Type::Handle(Type::Double()).type_class() == super_class.raw()) {
+ if (Type::Handle(Type::Double()).type_class() == super_class.raw() ||
+ Type::Handle(Type::IntType()).type_class() == super_class.raw()) {
regis 2012/09/12 16:30:25 I do not quite understand why kIntegerCid (and act
Lasse Reichstein Nielsen 2012/09/13 07:19:21 I think it worked for int before because it was an
is_error = true;
}
break;
@@ -1238,7 +1239,7 @@ void ClassFinalizer::ResolveInterfaces(const Class& cls,
if (!cls_belongs_to_core_lib) {
if (interface.IsBoolType() ||
interface.IsNumberType() ||
- interface.IsIntInterface() ||
+ interface.IsIntType() ||
interface.IsDoubleType() ||
interface.IsStringInterface() ||
(interface.IsFunctionType() && !cls.IsSignatureClass()) ||
« no previous file with comments | « lib/core/int.dart ('k') | runtime/vm/dart_api_message.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698