- Do not limit the compiler message buffer, by allocating the message

vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
@@ skipping 9482 matching lines @@
   }
   ASSERT(str.IsFourByteString());
   const FourByteString& fourstr = FourByteString::Cast(str);
   return fourstr.EscapeSpecialCharacters(raw_str);
 }
 
 
 RawString* String::NewFormatted(const char* format, ...) {
   va_list args;
   va_start(args, format);
-  intptr_t len = OS::VSNPrint(NULL, 0, format, args);
+  RawString* result = NewFormattedV(format, args);
+  NoGCScope no_gc;
   va_end(args);
+  return result;
+}
+
+
+RawString* String::NewFormattedV(const char* format, va_list args) {
+  va_list args_copy;
+  va_copy(args_copy, args);

[hausner, 2012/09/11 16:11:14]

I am not familiar with va_copy. Is va_start no longer needed due to the va_copy?

[Ivan Posva, 2012/09/11 16:14:39]

va_copy creates a copy of the passed in va_list args as the use of args is
destructive. Essentially it is in place of a va_start, which is used when
dealing with ... parameters.

+  intptr_t len = OS::VSNPrint(NULL, 0, format, args_copy);
+  va_end(args_copy);
 
   Zone* zone = Isolate::Current()->current_zone();
   char* buffer = zone->Alloc<char>(len + 1);
-  va_list args2;
-  va_start(args2, format);
-  OS::VSNPrint(buffer, (len + 1), format, args2);
-  va_end(args2);
+  OS::VSNPrint(buffer, (len + 1), format, args);
 
   return String::New(buffer);
 }
 
 
 RawString* String::Concat(const String& str1,
                           const String& str2,
                           Heap::Space space) {
   ASSERT(!str1.IsNull() && !str2.IsNull());
   intptr_t char_size = Utils::Maximum(str1.CharSize(), str2.CharSize());
@@ skipping 1974 matching lines @@
   }
   return result.raw();
 }
 
 
 const char* WeakProperty::ToCString() const {
   return "_WeakProperty";
 }
 
 }  // namespace dart