runtime/vm/flow_graph_compiler_ia32.cc - Issue 10933019: Improve moves of Smi and null objects. Add result cid to List constructor calls. Add tracing of inl…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 10933019: Improve moves of Smi and null objects. Add result cid to List constructor calls. Add tracing of inl… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

===================================================================

--- runtime/vm/flow_graph_compiler_ia32.cc (revision 12183)

+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)

@@ -1351,10 +1351,14 @@

void ParallelMoveResolver::StoreObject(const Address& dst, const Object& obj) {

// TODO(vegorov): allocate temporary register for such moves.

- __ pushl(EAX);

- __ LoadObject(EAX, obj);

- __ movl(dst, EAX);

- __ popl(EAX);

+ if (obj.IsSmi() || obj.IsNull()) {

+ __ movl(dst, Immediate(reinterpret_cast<int32_t>(obj.raw())));

+ } else {

+ __ pushl(EAX);

+ __ LoadObject(EAX, obj);

+ __ movl(dst, EAX);

+ __ popl(EAX);

+ }

}

« runtime/vm/flow_graph_builder.cc ('K') | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »