Improve moves of Smi and null objects. Add result cid to List constructor calls. Add tracing of inl…

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "vm/ast_printer.h"
 #include "vm/code_descriptors.h"
 #include "vm/dart_entry.h"
 #include "vm/flags.h"
@@ skipping 1644 matching lines @@
   arguments->Add(push_ctor_arg);
 
   BuildPushArguments(*node->arguments(), arguments);
   Do(new StaticCallInstr(node->token_pos(),
                          node->constructor(),
                          node->arguments()->names(),
                          arguments));
 }
 
 
+static intptr_t GetResultCidOfConstructor(ConstructorCallNode* node) {
+  if (node->constructor().IsFactory()) {
+    const Function& function = node->constructor();
+    const Library& core_impl_lib = Library::Handle(Library::CoreImplLibrary());
+    const Class& function_class = Class::Handle(function.Owner());
+
+    if (function_class.library() == core_impl_lib.raw()) {

[Vyacheslav Egorov (Google), 2012/09/11 12:30:40]

This code is very tied to the actual behavior of List-constructor.

Please make sure that we have good test coverage for this.

Additionally consider adding a comment in the List constructor that optimizer
relies on this.

[srdjan, 2012/09/11 15:23:16]

Done & Done

+      if (function_class.Name() == Symbols::ListImplementation()) {
+        if (function.name() == Symbols::ListFactory()) {
+          if (node->arguments()->length() == 0) {
+            return kGrowableObjectArrayCid;
+          } else {
+            ASSERT(node->arguments()->length() == 1);
+            return kArrayCid;
+          }
+        }
+      }
+    }
+  }
+  return kDynamicCid;   // Result cid not known.
+}
+
+
 void EffectGraphVisitor::VisitConstructorCallNode(ConstructorCallNode* node) {
   InlineBailout("EffectGraphVisitor::VisitConstructorCallNode");
   if (node->constructor().IsFactory()) {
     ZoneGrowableArray<PushArgumentInstr*>* arguments =
         new ZoneGrowableArray<PushArgumentInstr*>();
     PushArgumentInstr* push_type_arguments = PushArgument(
         BuildInstantiatedTypeArguments(node->token_pos(),
                                        node->type_arguments()));
     arguments->Add(push_type_arguments);
     ASSERT(arguments->length() == 1);
     BuildPushArguments(*node->arguments(), arguments);
     StaticCallInstr* call =
         new StaticCallInstr(node->token_pos(),
                             node->constructor(),
                             node->arguments()->names(),
                             arguments);
+    // List factories return kArrayCid or kGrowableObjectArrayCid.
+    call->set_result_cid(GetResultCidOfConstructor(node));
     ReturnDefinition(call);
     return;
   }
   // t_n contains the allocated and initialized object.
   //   t_n      <- AllocateObject(class)
   //   t_n+1    <- ctor-arg
   //   t_n+2... <- constructor arguments start here
   //   StaticCall(constructor, t_n+1, t_n+2, ...)
   // No need to preserve allocated value (simpler than in ValueGraphVisitor).
   Value* allocated_value = BuildObjectAllocation(node);
@@ skipping 961 matching lines @@
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, reason) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, function_name, reason);
   const Error& error = Error::Handle(
       LanguageError::New(String::Handle(String::New(chars))));
   Isolate::Current()->long_jump_base()->Jump(1, error);
 }
 
 
 }  // namespace dart