Speech JavaScript API: Use the MediaStreamManager to ask for user permission.

content/renderer/speech_recognition_dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/speech_recognition_dispatcher.h"
 
 #include "base/basictypes.h"
 #include "base/utf_string_conversions.h"
 #include "content/common/speech_recognition_messages.h"
 #include "content/renderer/render_view_impl.h"
@@ skipping 41 matching lines @@
   return handled;
 }
 
 void SpeechRecognitionDispatcher::start(
     const WebSpeechRecognitionHandle& handle,
     const WebSpeechRecognitionParams& params,
     WebSpeechRecognizerClient* recognizer_client) {
   DCHECK(!recognizer_client_ || recognizer_client_ == recognizer_client);
   recognizer_client_ = recognizer_client;
 
-  // TODO(primiano): Should return false in order to communicate the failure

[Satish, 2012/09/12 06:15:09]

Is this being removed because a different change already handles it?

[hans, 2012/09/12 09:46:58]

Yes, it's handled in WebKit.

-  // and let WebKit throw an exception (need a hans@ patch to do that).
-  if (HandleExists(handle))
-    return;
-
   SpeechRecognitionHostMsg_StartRequest_Params msg_params;
   for (size_t i = 0; i < params.grammars().size(); ++i) {
     const WebSpeechGrammar& grammar = params.grammars()[i];
     msg_params.grammars.push_back(
         content::SpeechRecognitionGrammar(grammar.src().spec(),
                                           grammar.weight()));
   }
   msg_params.language = UTF16ToUTF8(params.language());
   msg_params.is_one_shot = !params.continuous();
   msg_params.max_hypotheses = static_cast<uint32>(params.maxAlternatives());
@@ skipping 49 matching lines @@
   switch (e) {
     case content::SPEECH_RECOGNITION_ERROR_NONE:
       NOTREACHED();
       return WebSpeechRecognizerClient::OtherError;
     case content::SPEECH_RECOGNITION_ERROR_ABORTED:
       return WebSpeechRecognizerClient::AbortedError;
     case content::SPEECH_RECOGNITION_ERROR_AUDIO:
       return WebSpeechRecognizerClient::AudioCaptureError;
     case content::SPEECH_RECOGNITION_ERROR_NETWORK:
       return WebSpeechRecognizerClient::NetworkError;
+    case content::SPEECH_RECOGNITION_ERROR_NOT_ALLOWED:
+      return WebSpeechRecognizerClient::NotAllowedError;
     case content::SPEECH_RECOGNITION_ERROR_NO_SPEECH:
       return WebSpeechRecognizerClient::NoSpeechError;
     case content::SPEECH_RECOGNITION_ERROR_NO_MATCH:
       NOTREACHED();
       return WebSpeechRecognizerClient::OtherError;
     case content::SPEECH_RECOGNITION_ERROR_BAD_GRAMMAR:
       return WebSpeechRecognizerClient::BadGrammarError;
   }
   NOTREACHED();
   return WebSpeechRecognizerClient::OtherError;
@@ skipping 62 matching lines @@
   }
   return false;
 }
 
 const WebSpeechRecognitionHandle& SpeechRecognitionDispatcher::GetHandleFromID(
     int request_id) {
   HandleMap::iterator iter = handle_map_.find(request_id);
   DCHECK(iter != handle_map_.end());
   return iter->second;
 }