Issue 10930002: Fix android_build_commands.FileExistsOnDevice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10930002: Fix android_build_commands.FileExistsOnDevice (Closed)

Created:
8 years, 3 months ago by nduca

Modified:
8 years, 3 months ago

Reviewers:
Isaac (away)

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix android_build_commands.FileExistsOnDevice not "foo".find("bar") is not "foo".find("bar") == -1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/android/pylib/android_commands.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Isaac (away)

8 years, 3 months ago (2012-09-07 04:48:50 UTC) #2

sgtm, let's let them re-land this patch since it has some minor issues.