Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10928242: Switch OneClickSigninHelper to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, akalin, Raghu Simha, ajwong+watch_chromium.org, haitaol1, tim (not reviewing)
Visibility:
Public.

Description

Switch OneClickSigninHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157458

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -25 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.h View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 2 3 4 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Avi (use Gerrit)
Please review.
8 years, 3 months ago (2012-09-17 22:12:22 UTC) #1
Andrew T Wilson (Slow)
lgtm
8 years, 3 months ago (2012-09-17 23:03:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10928242/1
8 years, 3 months ago (2012-09-17 23:09:30 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-17 23:12:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10928242/1
8 years, 3 months ago (2012-09-17 23:26:13 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-18 00:11:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10928242/14002
8 years, 3 months ago (2012-09-18 01:09:04 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-18 05:39:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10928242/21001
8 years, 3 months ago (2012-09-18 14:15:14 UTC) #9
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-18 16:53:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10928242/24002
8 years, 3 months ago (2012-09-18 17:29:37 UTC) #11
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-18 20:06:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10928242/24005
8 years, 3 months ago (2012-09-18 20:53:45 UTC) #13
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 00:17:37 UTC) #14 
Change committed as 157458

Powered by Google App Engine
This is Rietveld 408576698