Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: content/renderer/browser_plugin/browser_plugin_browsertest.cc

Issue 10928237: Add support for parsing a 'partition' attribute on the <browser> tag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Testing Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin_bindings.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/browser_plugin/browser_plugin_browsertest.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_browsertest.cc b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
index 6cfcd3ee21f513204762253bc6ac5452f34b65c1..66a24c96142deb1a10758fd26e048f3f3c5ff280 100644
--- a/content/renderer/browser_plugin/browser_plugin_browsertest.cc
+++ b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
@@ -25,6 +25,17 @@ const char kHTMLForBrowserPluginObject[] =
"<object id='browserplugin' width='640px' height='480px'"
" src='foo' type='%s'>";
+const char kHTMLForSourcelessPluginObject[] =
+ "<object id='browserplugin' width='640px' height='480px' type='%s'>";
+
+const char kHTMLForPartitionedPluginObject[] =
+ "<object id='browserplugin' width='640px' height='480px'"
+ " src='foo' type='%s' partition='someid'>";
+
+const char kHTMLForPartitionedPersistedPluginObject[] =
+ "<object id='browserplugin' width='640px' height='480px'"
+ " src='foo' type='%s' partition='persist:someid'>";
+
std::string GetHTMLForBrowserPluginObject() {
return StringPrintf(kHTMLForBrowserPluginObject,
content::kBrowserPluginNewMimeType);
@@ -355,4 +366,104 @@ TEST_F(BrowserPluginTest, ReloadMethod) {
BrowserPluginHostMsg_Reload::ID));
}
+
+// Verify that the 'partition' attribute on the browser plugin is parsed
+// correctly.
+TEST_F(BrowserPluginTest, PartitionAttribute) {
+ std::string html = StringPrintf(kHTMLForPartitionedPluginObject,
+ content::kBrowserPluginNewMimeType);
+ LoadHTML(html.c_str());
+ std::string partition_value = ExecuteScriptAndReturnString(
+ "document.getElementById('browserplugin').partition");
+ EXPECT_STREQ("someid", partition_value.c_str());
+
+ html = StringPrintf(kHTMLForPartitionedPersistedPluginObject,
+ content::kBrowserPluginNewMimeType);
+ LoadHTML(html.c_str());
+ partition_value = ExecuteScriptAndReturnString(
+ "document.getElementById('browserplugin').partition");
+ EXPECT_STREQ("persist:someid", partition_value.c_str());
+
+ // Verify that once HTML has defined a source and partition, we cannot change
+ // the partition anymore.
+ ExecuteJavaScript(
+ "try {"
+ " document.getElementById('browserplugin').partition = 'foo';"
+ " document.title = 'success';"
+ "} catch (e) { document.title = e.message; }");
+ std::string title = ExecuteScriptAndReturnString("document.title");
+ EXPECT_STREQ(
+ "The object has already navigated, so its partition cannot be changed.",
+ title.c_str());
+
+ // Load a browser tag without 'src' defined.
+ html = StringPrintf(kHTMLForSourcelessPluginObject,
+ content::kBrowserPluginNewMimeType);
+ LoadHTML(html.c_str());
+
+ // Ensure we don't parse just "persist:" string and return exception.
+ ExecuteJavaScript(
+ "try {"
+ " document.getElementById('browserplugin').partition = 'persist:';"
+ " document.title = 'success';"
+ "} catch (e) { document.title = e.message; }");
+ title = ExecuteScriptAndReturnString("document.title");
+ EXPECT_STREQ("Invalid empty partition attribute.", title.c_str());
+}
+
+// Test to verify that after the first navigation, the partition attribute
+// cannot be modified.
+TEST_F(BrowserPluginTest, ImmutableAttributesAfterNavigation) {
+ std::string html = StringPrintf(kHTMLForSourcelessPluginObject,
+ content::kBrowserPluginNewMimeType);
+ LoadHTML(html.c_str());
+
+ ExecuteJavaScript(
+ "document.getElementById('browserplugin').partition = 'storage'");
+ std::string partition_value = ExecuteScriptAndReturnString(
+ "document.getElementById('browserplugin').partition");
+ EXPECT_STREQ("storage", partition_value.c_str());
+
+ std::string src_value = ExecuteScriptAndReturnString(
+ "document.getElementById('browserplugin').src");
+ EXPECT_STREQ("", src_value.c_str());
+
+ ExecuteJavaScript("document.getElementById('browserplugin').src = 'bar'");
+ {
+ const IPC::Message* msg =
+ browser_plugin_manager()->sink().GetUniqueMessageMatching(
+ BrowserPluginHostMsg_NavigateGuest::ID);
+ ASSERT_TRUE(msg);
+
+ int instance_id;
+ long long frame_id;
+ std::string src;
+ gfx::Size size;
+ BrowserPluginHostMsg_NavigateGuest::Read(
+ msg,
+ &instance_id,
+ &frame_id,
+ &src,
+ &size);
+ EXPECT_STREQ("bar", src.c_str());
+ }
+
+ // Setting the partition should throw an exception and the value should not
+ // change.
+ ExecuteJavaScript(
+ "try {"
+ " document.getElementById('browserplugin').partition = 'someid';"
+ " document.title = 'success';"
+ "} catch (e) { document.title = e.message; }");
+
+ std::string title = ExecuteScriptAndReturnString("document.title");
+ EXPECT_STREQ(
+ "The object has already navigated, so its partition cannot be changed.",
+ title.c_str());
+
+ partition_value = ExecuteScriptAndReturnString(
+ "document.getElementById('browserplugin').partition");
+ EXPECT_STREQ("storage", partition_value.c_str());
+}
+
} // namespace content
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin_bindings.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698